Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a DEB822 repo for Kali #83

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 20, 2024

🗣 Description

This pull request updates the Ansible role to use a DEB822 repo for Kali.

💭 Motivation and context

Kali recently updated to a version of the apt package that no longer provides the deprecated apt-key binary, so we cannot use ansible.builtin.apt_key to get the official Docker repo GPG key. Rather than download the key with ansible.builtin.get_url and create an old-style repo, I chose to upgrade to a newer-style DEB822 repo.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Dec 20, 2024
@jsf9k jsf9k self-assigned this Dec 20, 2024
Kali recently updated to a version of apt that no longer provides the
deprecated apt-key binary, so we cannot use ansible.builtin.apt_key to
get the official Docker repo GPG key.  We may as well upgrade to a
DEB822 repo while we're at it.
@jsf9k jsf9k force-pushed the bugfix/use-deb822-repo-for-kali branch from 24c91f0 to a78a4f9 Compare December 20, 2024 20:32
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k
Copy link
Member Author

jsf9k commented Dec 27, 2024

The Fedora 40 and 41 tests are failing because of fedora-cloud/docker-brew-fedora#117. See also this RedHat Bugzilla issue.

@jsf9k jsf9k force-pushed the bugfix/use-deb822-repo-for-kali branch from 175c100 to a78a4f9 Compare January 14, 2025 16:38
@jsf9k jsf9k merged commit 80865b4 into develop Jan 14, 2025
92 of 108 checks passed
@jsf9k jsf9k deleted the bugfix/use-deb822-repo-for-kali branch January 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants