Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage pull request for: skeleton #85

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Lineage pull request for: skeleton #85

merged 7 commits into from
Jan 24, 2025

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Jan 24, 2025

Lineage Pull Request

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-ansible-role.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

✅ Pre-approval checklist

  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jsf9k and others added 7 commits January 22, 2025 11:59
This is necessary when running Molecule tests against Fedora 40 and
41; otherwise, the privileged container cannot successfully sudo and
hence Ansible is unable to do anything.

Note that this change is reverted after the Molecule tests are run.

For now, disabling the unix-chkpwd AppArmor profile also requires an
apt-get purge of the firefox and passt packages.  It should be
possible to remove this purge (and the ensuing systemctl reload
apparmor.service) at a future date.  See
cisagov/skeleton-ansible-role#215 for more details.
These system packages had to be uninstalled to allow the disabling of
the unix-chkpwd AppArmor profile, but can be reinstalled at this
point.

Co-authored-by: Nicholas McDonnell <[email protected]>
…mor-profile

Disable `unix-chkpwd` AppArmor profile
This provides better and faster testing of ARM architectures than
testing under QEMU emulation.
We are no longer emulating ARM under QEMU, so using this GitHub Action
no longer causes the runners to run out of resources and crash.
Use native ARM runners when testing on ARM architecture
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Jan 24, 2025
@jsf9k jsf9k enabled auto-merge January 24, 2025 16:45
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code security This issue or pull request addresses a security issue labels Jan 24, 2025
@jsf9k jsf9k requested a review from a team January 24, 2025 17:01
@jsf9k jsf9k merged commit 26e8e01 into develop Jan 24, 2025
53 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch January 24, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use security This issue or pull request addresses a security issue upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants