This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Final touch ups for the modernization effort #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another `pip` package ecosystem for the `src/` directory so the `pipenv` configuration is seen and maintained by dependabot.
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook is intentionally held back to be updated independently to v6.
Update `pre-commit` hooks
Add a security label
Lineage pull request for: skeleton
When Dependabot creates a PR it requires this permission in order to push Docker images to ghcr.io.
Add package write permission to workflow
Co-authored-by: Nick <[email protected]>
Update wheel along with pip and setuptools
In this case it doesn't matter because we are starting from a Python3-specific base container, but other projects that use this skeleton may not be. Specifying pip3 ensures that the Python 2 version of pip is not called by mistake.
Specify the default group to run under in the Dockerfile
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…/build-push-action-4 Bump docker/build-push-action from 3 to 4
Specify pip3 in the file where it got blown away by a rebase
- Bump pip from 22.3.1 to 23.0 - Bump setuptools from 65.7.0 to 67.3.1 - Bump pipenv from 2022.12.19 to 2023.2.4
This was done by running `pipenv lock` in the `src/` directory.
This was missed when the version was bumped.
This includes the Docker images used as well as the version specified in the Pipfile.
Add some additional typing packges to improve analysis. Since this is a Docker project it doesn't make sense to install packages into the local Python environment for analysis.
mcdonnnj
added
improvement
jsf9k
approved these changes
Feb 15, 2023
Update the Docker configuration to use environment variables to house the versions of pip, pipenv, setuptools, and wheel that are installed directly in the Dockerfile. This will DRY out the configuration a bit as well as ensuring that the same versions are used for packages that are installed multiple times. The environment variable name format is cribbed from the official Python Docker image configuration: https://github.com/docker-library/python/blob/0a56f04a07495e0ed61663c73bc0c2e175773ddc/3.11/alpine3.17/Dockerfile#L132-L135 I tested without the leading `PYTHON_` in the names and only observed a failure for usage of `PIPENV_VERSION`. Following the above mentioned standard seemed like a reasonable approach as a result. Co-authored-by: Shane Frasier <[email protected]>
dav3r
reviewed
Feb 15, 2023
Since we regularly beat the drum about alphabetizing such things unless there are technical constraints we should definitely be alphabetizing these variables. Co-authored-by: dav3r <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
This pull request is a final "clean up" for the project modernization effort. It includes the following:
3.11.1to3.11.2.22.3.1to23.065.7.0to67.3.12022.12.19to2023.2.4🧪 Testing
Automated tests pass. I verified that the output of this prerelease matches the currently in production output.
✅ Pre-approval checklist