Update image dependencies #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
jsf9k
approved these changes
Aug 29, 2024
dv4harr10
approved these changes
Aug 29, 2024
This was referenced Aug 29, 2024
This includes updating all of the system packages installed to the versions available for Alpine Linux 3.20.
This updates the `build-stage` to match the versions of Python and Alpine Linux used in the `compile-stage`. This also includes updating the versions of all system packages installed.
Bump the Python packages installed in the `compile-stage` as follows: - pip from 23.1.2 to 24.2 - pipenv from 2023.10.20 to 2024.1.0 - setuptools from 67.7.2 to 75.1.0 - wheel from 0.40.0 to 0.44.0
Update the version of Python declared in the Pipfile and update the dependencies installed in the Python virtual environment by running `pipenv lock` in the `src/` directory.
Alpine Linux 3.20 configures Python 3 as externally managed, so we need to pass this flag to `pip` to install a Python package directly. Since we are using this to build a Python virtual environment in the `compile-stage` that is moved to the `build-stage` for use in the final image this should pose no issues.
mcdonnnj
force-pushed
the
maintenance/update_dependencies
branch
from
36a533c to
6abaa88
Compare
jsf9k
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the dependencies for this image including:
💭 Motivation and context
Keeping dependencies up-to-date is important for project health.
🧪 Testing
Automated tests mostly pass. The final image build fails because the image build exceeds the GitHub Actions runner timeout of six hours. The two most problematic platforms (
linux/ppc64leandlinux/s390x) will be dropped in another pull request and the build is able to complete successfully as seen in this workflow run.✅ Pre-approval checklist