Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the sesv2 boto3 client #158

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Use the sesv2 boto3 client #158

merged 3 commits into from
Oct 12, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Oct 9, 2024

🗣 Description

Note

This is copied from cisagov/cyhy-mailer#113 as this is a sibling pull request to the one created by @jsf9k.

This pull request updates the code to use the sesv2 boto3 client.

💭 Motivation and context

The SESv2 AWS API is the way forward. New features are only supported in the SESv2 API.

🧪 Testing

All automated tests pass. Confirmed successful run on my development docker instance.

TODO: Verify that the messages sent by code-gov-update are now showing up in the AWS SES Virtual Deliverability Manager.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.
  • Update the docker-compose.yml installed by cisagov/ansible-role-code-gov-update to use cisagov/code-gov-update:0.2.0.
  • Manually update the docker-compose.yml file on docker.prod-a.cyhy to use cisagov/code-gov-update:0.2.0.

mcdonnnj and others added 2 commits October 8, 2024 16:09
Previously we were using the older SES API. New features are only
supported in the AWS SESv2 API:
https://aws.amazon.com/blogs/messaging-and-targeting/upgrade-your-email-tech-stack-with-amazon-sesv2-api/

Co-authored-by: Shane Frasier <[email protected]>
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation python Pull requests that update Python code labels Oct 9, 2024
@mcdonnnj mcdonnnj self-assigned this Oct 9, 2024
@mcdonnnj mcdonnnj marked this pull request as ready for review October 10, 2024 18:22
@mcdonnnj mcdonnnj requested review from dav3r and jsf9k as code owners October 10, 2024 18:22
@mcdonnnj mcdonnnj merged commit fd062ec into develop Oct 12, 2024
17 checks passed
@mcdonnnj mcdonnnj deleted the improvement/use_sesv2_client branch October 12, 2024 04:40
cisagovbot pushed a commit that referenced this pull request Dec 6, 2024
…s/setup-go-5

Bump actions/setup-go from 4 to 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants