Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the image's authors label #179

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Update the image's authors label #179

merged 1 commit into from
Jan 15, 2025

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the org.opencontainers.image.authors label defined in the Dockerfile.

💭 Motivation and context

We no longer use the old email address so we should update to the current one for our team. This also resolves #168 (comment).

🧪 Testing

Automated tests pass. I also inspected a built test image to verify the label was there as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use docker Pull requests that update Docker code labels Jan 15, 2025
@mcdonnnj mcdonnnj requested a review from a team January 15, 2025 21:17
@mcdonnnj mcdonnnj self-assigned this Jan 15, 2025
@mcdonnnj mcdonnnj requested review from dav3r and jsf9k as code owners January 15, 2025 21:17
@mcdonnnj mcdonnnj mentioned this pull request Jan 15, 2025
Merged
7 tasks
@mcdonnnj mcdonnnj merged commit 7c40a2f into develop Jan 15, 2025
17 checks passed
@mcdonnnj mcdonnnj deleted the improvement/update_author_label branch January 15, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
docker Pull requests that update Docker code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dv4harr10