Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for disabled platforms #180

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Restore support for disabled platforms #180

wants to merge 2 commits into from

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jan 15, 2025 •
edited
Loading

🗣 Description

This pull request restores support for the following platforms that were previously disabled:

  • linux/arm/v6
  • linux/ppc64le
  • linux/s390x

💭 Motivation and context

Now that we are installing the cryptography Python package using the Alpine Linux system package we no longer need to worry about building wheels when creating the image. This allows us to restore support for these platforms since we are now able to build the image well before the GitHub Actions runtime limit of ~6 hours is exceeded.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a pre-release.

@mcdonnnj
Restore support for dropped platforms
f1fd307 
Now that we are installing the `cryptography` package through the
`py3-cryptography` system package we should be able to support any
platforms that the package does. This means we can restore support for
the `linux/arm/v6`, `linux/ppc64le`, and `linux/s390x` platforms.
@mcdonnnj
Bump version from 0.3.0-rc.2 to 0.3.0-rc.3
d26a1de
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number github-actions Pull requests that update GitHub Actions code labels Jan 15, 2025
@mcdonnnj mcdonnnj self-assigned this Jan 15, 2025
@mcdonnnj mcdonnnj requested a review from a team January 15, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @dv4harr10