-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in upstream updates #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement bandit config
Also update the URL for black since it moved GitHub orgs from ambv to python.
Run pre-commit autoupdate
…ss_yamllint Make .bandit.yml pass yamllint
This should speed up TravisCI builds.
Via pre-commit autoupdate.
Use TravisCI caching to speed up builds
Add changes from running pre-commit autoupdate
terraform-docs is currently broken with respect to terraform 0.12.
Remove the terraform-docs hook
JSON files are already being linted by the pretty-format-json hook.
…re_json_files Configure prettier to ignore JSON files
Update two text blocks to use the console tag instead of the bash tag…
This config file turns off the "line too long" rule when within a code block or a table. Often there is no way to avoid going over 80 lines in such cases.
The license text is not actually in Markdown, and adding the .md extension actually makes it render a little differently than intended.
Add markdownlint config
…t_autoupdate Add updates from running pre-commit autoupdate
…t_autoupdate Add updates from running pre-commit autoupdate
setup-env: A tool to automate a development environment setup.
Notable version changes: - docker-pre-commit v2.0.0 This release includes the addition of two new hooks: hadolint and hadolint-system. These allow for linting Dockerfiles with the hadolint Docker image or a system installation of hadolint respectively. - isort 5.0.7 This release takes us from isort 4 to isort 5. There are a multitude of changes with information available on the isort 5 release page at https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/ The most notable feature for us is the addition of built-in profiles for isort to run under. These profiles provide settings for conforming to various popular styles, and black is one of the profiles.
Autoupdates to pre-commit Hooks for 2020-07
Switch the workflow to use cachev2. This puts us up to date and allows us to consolidate into one cache item.
Keep it up-to-date even though we are not currently using features added in v2.
Make the job name the first part of the cache key since it is the only part that isn't variable.
…nd_cache_actions_to_v2 Update actions/cache and actions/setup-python to v2
Autoupdate pre-commit and Additional Maintenance
…ent/upstream-updates
mcdonnnj
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing another one into the light 🔦 Please see my comment about some documentation that got missed.
dav3r
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request pulls in upstream changes from cisagov/skeleton-generic.
💭 Motivation and Context
I plan to make some changes to the code-gov-update deployment related to cisagov/cyhy_amis#279, so it makes sense to go ahead and update all the related repositories.
🧪 Testing
All pre-commit hooks pass.
🚥 Types of Changes
✅ Checklist