Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test harness endpoints from Release build #4359

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

randywoods
Copy link
Collaborator

Two endpoints for test harness usage expose the connection string. This fix uses preprocessor code to exclude them from a Release build.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Two endpoints for test harness usage expose the connection string.  This fix uses preprocessor code to exclude them from a Release build.
@Marcus-Goectau Marcus-Goectau merged commit f41a6b7 into develop Jan 16, 2025
4 checks passed
@Marcus-Goectau Marcus-Goectau deleted the feature/CSET-2975 branch January 16, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants