Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eradicate Trio references #91

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Eradicate Trio references #91

merged 3 commits into from
Jun 30, 2023

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jun 30, 2023

🗣 Description

This PR removes all remaining references to Trio email addresses and replaces them with something more appropriate.

💭 Motivation and context

We are winding down our usage of Trio, so we must clean up these old references.

🧪 Testing

Tested via visual inspection. 👀

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@dav3r dav3r added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Jun 30, 2023
@dav3r dav3r self-assigned this Jun 30, 2023
jsf9k
jsf9k approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please have a look at my one comment.

config/gitleaks.toml Show resolved Hide resolved
@jsf9k jsf9k mentioned this pull request Jun 30, 2023
Open
@dav3r dav3r merged commit 84ebd41 into develop Jun 30, 2023
@dav3r dav3r deleted the improvement/eradicate-trio-references branch June 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@jasonodoom jasonodoom jasonodoom approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@dav3r dav3r

Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dav3r @jsf9k @jasonodoom