Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lovesegfault/beautysh directive #111

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 31, 2024

🗣 Description

This pull request removes an unnecessary lovesegfault/beautysh directive. It also updates the Dockerfile to use the most recent incarnation of our VM developer distro email address.

💭 Motivation and context

We no longer use lovesegfault/beautysh for linting, so there is no longer any need to work around its limitations.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

We no longer use that tool for linting, so there is no longer any need
to work around its limitations.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jan 31, 2024
@jsf9k jsf9k self-assigned this Jan 31, 2024
@jsf9k jsf9k marked this pull request as ready for review January 31, 2024 18:05
@jsf9k jsf9k requested a review from a team January 31, 2024 18:05
@jsf9k jsf9k enabled auto-merge January 31, 2024 18:06
@jsf9k jsf9k merged commit ad8efff into develop Jan 31, 2024
18 checks passed
@jsf9k jsf9k deleted the improvement/remove-unnecessary-beauty.sh-directive branch January 31, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants