Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #22

Merged
merged 17 commits into from
Feb 22, 2021
Merged

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Feb 17, 2021

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-docker.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone [email protected]:cisagov/gophish-docker.git gophish-docker
    cd gophish-docker
    git remote add skeleton https://github.com/cisagov/skeleton-docker.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add bump_version.sh 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 16 commits January 15, 2021 10:36
This hook performs auto-formatting (beautifying) of Bash scripts.
Our other skeletons have this file, even if they are not Python projects. The
directions in CONTRIBUTING.md reference such a file, which can be misleading.
Rather than amending the CONTRIBUTING documentation, I feel it's better to
align with our other skeletons for consistency.
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
Lineage pull request for: skeleton
Correct the Agency Name for Docker Images
Add a requirements-dev.txt pip Requirements File
@dav3r dav3r added the upstream update This issue or pull request pulls in upstream updates label Feb 17, 2021
@dav3r dav3r marked this pull request as ready for review February 17, 2021 21:20
@dav3r dav3r self-requested a review as a code owner February 17, 2021 21:20
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥡

@dav3r dav3r merged commit bb4eafd into develop Feb 22, 2021
@dav3r dav3r deleted the lineage/skeleton branch February 22, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants