Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade base Docker image to Debian Bullseye #52

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Upgrade base Docker image to Debian Bullseye #52

merged 2 commits into from
Oct 19, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 18, 2022 •
edited
Loading

🗣 Description

This pull request upgrades the base Docker image from Debian Buster to Debian Bullseye.

💭 Motivation and context

Resolves #51.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

jsf9k added 2 commits October 18, 2022 09:35
@jsf9k
Update the base Docker image
699ac0f 
The buster image does not currently support all the hardware platforms
we want.
@jsf9k
Bumping version from 0.0.6 to 0.0.7
afb9f39
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 18, 2022
@jsf9k jsf9k self-assigned this Oct 18, 2022
@jsf9k jsf9k marked this pull request as ready for review October 18, 2022 14:34
dav3r
dav3r approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll with the changes ⚙️

@jsf9k
Copy link
Member Author

jsf9k commented Oct 19, 2022

Roll with the changes gear

https://www.youtube.com/watch?v=b9_7ByKnwWY

mcdonnnj
mcdonnnj approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough. ✔

@jsf9k jsf9k merged commit d107a5d into develop Oct 19, 2022
@jsf9k jsf9k deleted the improvement/upgrade-base-docker-image branch October 19, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Debian Bullseye
3 participants
@jsf9k @dav3r @mcdonnnj