Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to using the main repos for TheWover/donut and RedSiege/EXCELntDonut #175

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Revert to using the main repos for TheWover/donut and RedSiege/EXCELntDonut #175

merged 5 commits into from
Oct 23, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 23, 2024 •
edited
Loading

🗣 Description

This pull request reverts to using the default repositories for TheWover/donut and RedSiege/EXCELntDonut.

💭 Motivation and context

Resolves #173 and #174.

🧪 Testing

All automated tests pass. I also built and deployed a staging AMI with these changes and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a staging AMI with these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

jsf9k added 4 commits October 23, 2024 09:35
@jsf9k
Revert to using TheWover/donut
848c817 
There is no longer any need to use my fork now that TheWover/donut#158
has been merged.

Resolves #173.
@jsf9k
Revert to using RedSiege/EXCELntDonut
8a607f3 
There is no longer any need to use my fork now that TheWover/donut#158
has been merged.

Resolves #174.
@jsf9k
Bump version from 0.5.29 to 0.5.30
470883c
@jsf9k
Bump version from 0.5.30 to 0.5.30-rc.1
b6aa36a
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation packer Pull requests that update Packer code labels Oct 23, 2024
@jsf9k jsf9k self-assigned this Oct 23, 2024
@jsf9k jsf9k linked an issue Oct 23, 2024 that may be closed by this pull request
Revert to RedSiege/EXCELntDonut #174
Closed
@jsf9k jsf9k marked this pull request as ready for review October 23, 2024 17:29
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners October 23, 2024 17:29
@jsf9k jsf9k requested a review from a team October 23, 2024 17:30
dav3r
dav3r approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

lwersiy
lwersiy approved these changes Oct 23, 2024
View reviewed changes
Copy link

@lwersiy lwersiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsf9k jsf9k enabled auto-merge October 23, 2024 17:50
@jsf9k jsf9k merged commit aad32b4 into develop Oct 23, 2024
8 checks passed
@jsf9k jsf9k deleted the improvement/revert-to-main-repo-for-donut-and-excelntdonut branch October 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwersiy lwersiy lwersiy approved these changes

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use packer Pull requests that update Packer code version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert to RedSiege/EXCELntDonut Revert to TheWover/donut
3 participants
@jsf9k @dav3r @lwersiy