Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the GitHubSecurityLab/actions-permissions/monitor action #178

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Re-enable the GitHubSecurityLab/actions-permissions/monitor action #178

wants to merge 1 commit into from
+12 −18

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 20, 2024

🗣 Description

This pull request re-enables the GitHubSecurityLab/actions-permissions/monitor action.

💭 Motivation and context

With the merge of GitHubSecurityLab/actions-permissions#34, this proxy no longer interferes with AWS API or boto3 calls.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code security This issue or pull request addresses a security issue labels Dec 20, 2024
@jsf9k jsf9k self-assigned this Dec 20, 2024
@jsf9k jsf9k force-pushed the improvement/re-enable-permissions-proxy branch from ba15c19 to 19612fa Compare January 15, 2025 22:09
@jsf9k jsf9k marked this pull request as ready for review January 15, 2025 22:09
@jsf9k jsf9k requested a review from a team January 15, 2025 22:10
dav3r
dav3r approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ansible/assessor_tools.yml Outdated Show resolved Hide resolved
@jsf9k jsf9k force-pushed the improvement/re-enable-permissions-proxy branch from 19612fa to 198eed6 Compare January 16, 2025 13:57
@jsf9k
Re-enable the GitHubSecurityLab/actions-permissions/monitor action
d166c85 
With the merge of GitHubSecurityLab/actions-permissions#34, this proxy
no longer interferes with AWS API or boto3 calls.
@jsf9k jsf9k force-pushed the improvement/re-enable-permissions-proxy branch from 198eed6 to d166c85 Compare January 17, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@jsf9k jsf9k

Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use security This issue or pull request addresses a security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsf9k @dav3r