Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading styles #3190

Closed
4 tasks done
gabydisarli opened this issue Dec 5, 2024 · 1 comment · Fixed by #3358
Closed
4 tasks done

Update heading styles #3190

gabydisarli opened this issue Dec 5, 2024 · 1 comment · Fixed by #3358
Assignees
Labels
design issue is for the design team dev issue is for the dev team

Comments

@gabydisarli
Copy link
Contributor

gabydisarli commented Dec 5, 2024

Issue description

We use different heading styles across the app which leads to a disjointed experience for our users. There has been lots of customized heading classes over the course of the project which is hard to manage on the design and dev side. We should have a family of heading styles that can be used across the request form and domain management pages.

Both design and dev should work together to find all heading differences and determine a resolution.

Acceptance criteria

  • Dev and Designer audit the code for all existing classes of H1,H2,H3,etc
  • Dev, work with a designer to unify heading styles to follow Figma design system
  • Dev: changes to any heading/text changes desired by the designer are considered in scope and changed
  • Dev: if applicable, refactor areas of our scss using/defining these headers if deemed necessary.

Additional context

Note: These notes are relevant to our H3 style only.
We override the h3 in several areas. The screenshots are of the Senior official page, the domain overview page, and domain request page. There are other areas in the code where we are overwriting h3 that are not pictured here.
Align h3 class to have these properties

  • font size: 1.2 em
  • line height: 1.15
  • font weight: 600 semi-bold
    See slack thread for other areas where we are overriding h3.
@gabydisarli gabydisarli added the dev issue is for the dev team label Dec 5, 2024
@gabydisarli gabydisarli added the design issue is for the design team label Dec 30, 2024
@gabydisarli gabydisarli changed the title Update h3 style Update heading styles Dec 30, 2024
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Dec 31, 2024
@gabydisarli gabydisarli moved this from 🎯 Ready to 🏗 In progress in .gov Product Board Jan 13, 2025
@gabydisarli
Copy link
Contributor Author

Rachid's PR is up and its conditionally approved with some minor changes. See audit spreadsheet for more detail on our final heading decisions.

@gabydisarli gabydisarli moved this from 🏗 In progress to ✅ Done in .gov Product Board Jan 22, 2025
@gabydisarli gabydisarli closed this as completed by moving to ✅ Done in .gov Product Board Jan 22, 2025
rachidatecs added a commit that referenced this issue Jan 24, 2025
#3190: Heading refactor and other CSS fixes - [no sandbox]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue is for the design team dev issue is for the dev team
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants