Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3280: Review member permissions in registrar [LITTERBOX] #3325

Merged
merged 69 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
5c127ed
Change admin tag color, weight, and casing
zandercymatics Jan 10, 2025
ac02755
Always show the "view assigned domains" link
zandercymatics Jan 10, 2025
fc2c6b5
Last active, small text, base-dark, "domain" vs "domains"
zandercymatics Jan 15, 2025
af26a36
Update table-members.js
zandercymatics Jan 15, 2025
32e5cfe
fix bug
zandercymatics Jan 15, 2025
036c10e
Fix last table row + modal changes
zandercymatics Jan 15, 2025
3aa493d
Fix bugs
zandercymatics Jan 15, 2025
f775818
change kebab style
zandercymatics Jan 16, 2025
ee4629b
Revert "change kebab style"
zandercymatics Jan 16, 2025
c8ac9c4
Fix error styling on member page
zandercymatics Jan 16, 2025
f7c38e9
Update test_views_portfolio.py
zandercymatics Jan 16, 2025
9cb6179
Add aria information
zandercymatics Jan 17, 2025
548953e
Code cleanup
zandercymatics Jan 17, 2025
eab7b79
Update aria label for kebab on member page
zandercymatics Jan 17, 2025
0c3a2a5
Fix table definition
zandercymatics Jan 17, 2025
dfc9b47
Fix table tabbing
zandercymatics Jan 17, 2025
91c1949
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 17, 2025
a5b293d
fix js compilation error
zandercymatics Jan 17, 2025
134a97e
Add VO changes
zandercymatics Jan 21, 2025
4b0b294
Follow-on bug fixes
zandercymatics Jan 21, 2025
bfec91e
Update member_domains_edit_table.html
zandercymatics Jan 21, 2025
395e0ff
Update table-members.js
zandercymatics Jan 21, 2025
7df035a
Simplify tab logic
zandercymatics Jan 21, 2025
66d3844
Swap to using tableAnnouncementRegion exclusively
zandercymatics Jan 21, 2025
f836289
Update table-edit-member-domains.js
zandercymatics Jan 21, 2025
c462264
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 21, 2025
295e7f2
Fix error message and header spacing on domain assignments page
zandercymatics Jan 23, 2025
8491ef3
Merge branch 'main' into za/3280-design-review
zandercymatics Jan 23, 2025
9d07d4f
Merge branch 'za/3307-duplicate-key-bug' into za/3280-design-review
zandercymatics Jan 23, 2025
35acd26
Fix spacing between breadcrumb and header
zandercymatics Jan 23, 2025
0a10d2d
Fix spacing between h2 and search bar
zandercymatics Jan 23, 2025
f55f497
Fix <p> spacing and make table span wider
zandercymatics Jan 23, 2025
060e4b9
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 23, 2025
e68423c
Merge branch 'za/3280-design-review' into litterbox/3280-design-review
zandercymatics Jan 23, 2025
f203c99
fix test
zandercymatics Jan 23, 2025
2ae0167
Add space between strings (whoops)
zandercymatics Jan 23, 2025
ea1fcf7
Add nosec: Overzealous linter
zandercymatics Jan 23, 2025
c5b9984
Update test_views_portfolio.py
zandercymatics Jan 23, 2025
da1eb67
Fix color override + fix table margin / padding
zandercymatics Jan 24, 2025
31cdb7e
Update portfolio_member_domains_edit.html
zandercymatics Jan 24, 2025
615f8b0
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 24, 2025
0be3d48
Merge remote-tracking branch 'origin/rjm/3190-heading-refactor' into …
zandercymatics Jan 24, 2025
01497bf
Review changes for domain assignments page
zandercymatics Jan 24, 2025
130cfc9
Fix email send bug, scroll to top, fix search issue
zandercymatics Jan 24, 2025
78f31e9
Fix background color and font weight on usa tag
zandercymatics Jan 24, 2025
e0979d0
placeholder email
zandercymatics Jan 24, 2025
0702e97
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 24, 2025
0540f0c
Changes
zandercymatics Jan 24, 2025
645aa53
alphabetize logic
zandercymatics Jan 24, 2025
de8b264
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 24, 2025
4096308
Better error handling for fixtures_users
zandercymatics Jan 27, 2025
5a32b07
Update email_invitations.py
zandercymatics Jan 27, 2025
2cc63f4
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 27, 2025
d793894
Fix member modal not displaying name
zandercymatics Jan 27, 2025
82c2281
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 27, 2025
3544596
PR suggestions (pt 1)
zandercymatics Jan 27, 2025
6c074bd
Cleanup css
zandercymatics Jan 27, 2025
e2c2813
Update email_invitations.py
zandercymatics Jan 27, 2025
9b1d1d1
Fix data-member bug
zandercymatics Jan 28, 2025
241b43e
Attempt to fix border-bottom
zandercymatics Jan 28, 2025
b078149
Update _tables.scss
zandercymatics Jan 28, 2025
4dd9b99
Fix unit test
zandercymatics Jan 28, 2025
477f9ce
Target ID rather than CLASS
zandercymatics Jan 28, 2025
3c3ce69
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 28, 2025
e681f10
Update table-members.js
zandercymatics Jan 28, 2025
ad2c04d
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 28, 2025
e7243b7
PR suggestions
zandercymatics Jan 28, 2025
d68a338
Remove tabindex
zandercymatics Jan 28, 2025
6f39eac
Merge branch 'main' into litterbox/3280-design-review
zandercymatics Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spacing between h2 and search bar
zandercymatics committed Jan 23, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 0a10d2dbfdbe1ac3f135a77c4c085ef9baab5e25
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ <h2>
<div class="section-outlined__header margin-bottom-3 grid-row">
<!-- ---------- SEARCH ---------- -->
<div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9">
<section aria-label="Member domains search component" class="margin-top-2">
<section aria-label="Member domains search component">
<form class="usa-search usa-search--show-label" method="POST" role="search">
{% csrf_token %}
<label class="usa-label display-block margin-bottom-05" for="edit-member-domains__search-field">
2 changes: 1 addition & 1 deletion src/registrar/templates/includes/member_domains_table.html
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ <h2>
<div class="section-outlined__header margin-bottom-3 grid-row" id="edit-member-domains__search">
<!-- ---------- SEARCH ---------- -->
<div class="section-outlined__search mobile:grid-col-12 desktop:grid-col-9">
<section aria-label="Member domains search component" class="margin-top-2">
<section aria-label="Member domains search component">
<form class="usa-search usa-search--show-label" method="POST" role="search">
{% csrf_token %}
<label class="usa-label display-block margin-bottom-05" for="member-domains__search-field">