Get rid of Python warning about use of deprecated function #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime.now(datetime.UTC) is the preferred way to do the same thing. Resolves #88.
The previous version incorrectly triggers on some Python strings containing colons so we need the updated hook here; otherwise, we get errors that look like: src/report/generate_https_scan_report.py:772:38: E231 missing whitespace after ':' src/report/graphs.py:186:39: E231 missing whitespace after ':' src/report/graphs.py:186:40: E231 missing whitespace after ',' src/report/graphs.py:586:77: E231 missing whitespace after ':' src/report/graphs.py:589:47: E231 missing whitespace after ':' src/report/graphs.py:640:74: E231 missing whitespace after ':' src/report/graphs.py:641:66: E231 missing whitespace after ':'
jsf9k
added
improvement
datetime.UTC is an alias for datetime.timezone.utc, but it is only available as of version 3.11 of Python. For more information see: https://docs.python.org/3/library/datetime.html#datetime.UTC
dv4harr10
approved these changes
Nov 27, 2023
dav3r
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request gets rid of a warning about the use of a deprecated function in the Python
datetimelibrary.💭 Motivation and context
Resolves #88.
🧪 Testing
All automated tests pass. I also built a new Docker image with these changes and verified that it functions as expected.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist