Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the latest version of pshtt #69

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Use the latest version of pshtt #69

merged 4 commits into from
Dec 5, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 5, 2022 •
edited
Loading

🗣 Description

This pull request modifies the Docker container to use the latest release of cisagov/pshtt.

💭 Motivation and context

The most recent release of cisagov/pshtt contains a fix for a broken URL. See cisagov/orchestrator#67 for more details.

🧪 Testing

All automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Dec 5, 2022
@jsf9k jsf9k self-assigned this Dec 5, 2022
@jsf9k jsf9k marked this pull request as ready for review December 5, 2022 17:31
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners December 5, 2022 17:31
dav3r
dav3r approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit 9acc1c3 into develop Dec 5, 2022
@jsf9k jsf9k deleted the improvement/use-latest-pshtt branch December 5, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj