Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #73

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Bump version #73

merged 1 commit into from
Dec 23, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 23, 2022 •
edited
Loading

🗣 Description

This pull request bumps the version so we can rebuild and pick up the latest changes from cisagov/domain-scan.

💭 Motivation and context

The pshtt timeout was lengthened from 5 to 7 seconds in cisagov/domain-scan#1.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number labels Dec 23, 2022
@jsf9k jsf9k self-assigned this Dec 23, 2022
@jsf9k jsf9k marked this pull request as ready for review December 23, 2022 19:59
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners December 23, 2022 19:59
dav3r
dav3r approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mcdonnnj
mcdonnnj approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ⏱️

@jsf9k jsf9k merged commit 2a4008a into develop Dec 23, 2022
@jsf9k jsf9k deleted the bump-version branch December 23, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@jsf9k jsf9k

Labels
upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj