Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to cisagov fork of domain-scan #74

Merged
merged 9 commits into from
Jan 30, 2023
Merged

Switch to cisagov fork of domain-scan #74

merged 9 commits into from
Jan 30, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 30, 2023 •
edited
Loading

🗣 Description

This pull request modifies the Docker container to use the cisagov fork of 18F/domain-scan, as well as teh latest release of cisagov/pshtt.

💭 Motivation and context

This should have been done as part of the work done around #1, but it was not.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number docker Pull requests that update Docker code labels Jan 30, 2023
@jsf9k jsf9k self-assigned this Jan 30, 2023
@jsf9k jsf9k marked this pull request as ready for review January 30, 2023 18:56
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners January 30, 2023 18:56
dav3r
dav3r approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mcdonnnj
mcdonnnj approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also mention that you bumped pshtt versions in the pull request description?

@jsf9k jsf9k merged commit d4a22a4 into develop Jan 30, 2023
@jsf9k jsf9k deleted the improvement/switch_to_cisagov_fork branch January 30, 2023 21:04
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Feb 1, 2023
@jsf9k
Use the latest gatherer and scanner Docker images
aaee297 
See cisagov/gatherer#96 and cisagov/scanner#74 for more details.
@jsf9k jsf9k mentioned this pull request Feb 1, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality docker Pull requests that update Docker code version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj