-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terraform-docs version #31
Conversation
Co-authored-by: Nick M. <[email protected]>
Co-authored-by: Nick M. <[email protected]>
4007f32
to
d130605
Compare
Note that this change is dependent on the merging of cisagov/setup-env-github-action#31. Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this side! Some great improvement and it's good to get this under version control for consistency. Just one fix and I should be good to approve this PR.
The terraform-docs version starts with a `v` character. Co-authored-by: Nick M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I threw this into a workflow in my personal GHA testing repo and it looks like everything installs as expected:
packer --version
terraform --version
terraform-docs --version
shell: /usr/bin/bash -e {0}
env:
CURL_CACHE_DIR: ~/.cache/curl
PIP_CACHE_DIR: ~/.cache/pip
PRE_COMMIT_CACHE_DIR: ~/.cache/pre-commit
RUN_TMATE:
PACKER_VERSION: 1.6.6
TERRAFORM_VERSION: 0.12.31
TERRAFORM_DOCS_VERSION: v0.14.1
pythonLocation: /opt/hostedtoolcache/Python/3.9.5/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.5/x64/lib
GOROOT: /opt/hostedtoolcache/go/1.16.5/x64
GO_VERSION: 1.16.5
1.6.6
Terraform v0.12.31
Your version of Terraform is out of date! The latest version
is 1.0.2. You can update by downloading from https://www.terraform.io/downloads.html
terraform-docs version v0.14.1 linux/amd64
Nice shades Frasier!
Thanks for testing it. πββοΈ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yessir, I like this! π
Note that this change is dependent on the merging of cisagov/setup-env-github-action#31. Co-authored-by: Nick M. <[email protected]>
π£ Description
This pull request adds a
terraform-docs
version toentrypoint.sh
.π Motivation and context
See this pull request comment.
π§ͺ Testing
All
pre-commit
hooks pass.β Checklist