Update some outdated items in the project #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
the
improvement
Merged
8 tasks
dav3r
approved these changes
Jun 30, 2022
cisagovbot
pushed a commit
that referenced
this pull request
Nov 8, 2022
…s/setup-python-4 Bump actions/setup-python from 3 to 4
This argument references a file that is no longer found in the repository. The configuration also no longer uses any such files so it is safe to remove this as opposed to updating it instead.
Add all requirements*.txt files in the configuration to this file. This ensures that all requirements in use are being used for scanning.
Until we completely remove LGTM from our repositories we should keep at least the minimum badging. This project does not directly use any Python, JavaScript, etc. so I am enabling the "Total alerts" badge. Other possibilities are commented out to make it easier for downstream repositories to enable what suits their configurations.
mcdonnnj
force-pushed
the
improvement/fix_dangling_configurations
branch
from
1b94368 to
42f3468
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates some old changes that do not align with this project as it is now. This includes:
requirements*.txtfiles to the LGTM configuration.💭 Motivation and context
@dav3r noticed in cisagov/code-gov-update#30 that there was an argument in our pre-commit configuration for a file that was no longer in this project. That led me to do a quick review for similar items and this pull request is the result.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.