Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the default group to run under in the Dockerfile #141

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Specify the default group to run under in the Dockerfile #141

merged 1 commit into from
Feb 10, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 22, 2022 •
edited
Loading

🗣 Description

This pull request specifies the default group to run under in the Dockerfile.

💭 Motivation and context

Doesn't hurt. May as well.

🧪 Testing

All automated tests pass. I have been doing this in cisagov/gatherer for years.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Nov 22, 2022
@jsf9k jsf9k self-assigned this Nov 22, 2022
@jsf9k jsf9k marked this pull request as ready for review November 22, 2022 17:28
mcdonnnj
mcdonnnj approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 👍

dav3r
dav3r approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 2, 2023
@jmorrowomni jmorrowomni force-pushed the improvement/specify-group branch from 2253a89 to d6bf3c0 Compare February 10, 2023 02:39
@jmorrowomni jmorrowomni merged commit 83baee5 into develop Feb 10, 2023
@jmorrowomni jmorrowomni deleted the improvement/specify-group branch February 10, 2023 02:47
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
@mcdonnnj
Merge pull request #141 from cisagov/documentation/grammar
338e3e1 
Delete duplicate word "are"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @jmorrowomni