Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package write permission to workflow #144

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add package write permission to workflow #144

merged 1 commit into from
Feb 10, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 6, 2022 •
edited
Loading

🗣 Description

This pull requests adds the packages: write permission for the build-push-all portion of the workflow.

💭 Motivation and context

When Dependabot creates a PR this permission is required in order to push Docker images to ghcr.io.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added bug This issue or pull request addresses broken functionality blocked This issue or pull request is awaiting the outcome of another issue or pull request github-actions Pull requests that update GitHub Actions code kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Dec 6, 2022
@jsf9k jsf9k self-assigned this Dec 6, 2022
@jsf9k jsf9k marked this pull request as ready for review December 6, 2022 16:32
dav3r
dav3r approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖊️

@mcdonnnj mcdonnnj removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 9, 2023
@jsf9k @jmorrowomni
Add package write permission to workflow
da15398 
When Dependabot creates a PR it requires this permission in order to
push Docker images to ghcr.io.
@jmorrowomni jmorrowomni force-pushed the bugfix/add-package-permission branch from 29fe38a to da15398 Compare February 10, 2023 01:58
@jmorrowomni jmorrowomni merged commit 3c9fc65 into develop Feb 10, 2023
@jmorrowomni jmorrowomni deleted the bugfix/add-package-permission branch February 10, 2023 02:07
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
@mcdonnnj
Merge pull request #144 from cisagov/improvement/add-github-status-jazz
c0eed09 
Add a job that runs diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jmorrowomni jmorrowomni jmorrowomni approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @jmorrowomni @mcdonnnj