Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify pip3 in the file where it got blown away by a rebase #154

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

jmorrowomni
Copy link
Contributor

@jmorrowomni jmorrowomni commented Feb 10, 2023

Specify pip3 in the file where it got blown away by a rebase

🗣 Description

Specify pip3 in the file where it got blown away by a rebase

💭 Motivation and context

PR #142 replaced all instances of pip with pip3. During a rebase
after merging PR #143, there was a conflict where a single instance of
this change was accidentally blown away and needs to be restored.

🧪 Testing

No additional testing required as all tests passed in #142.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jmorrowomni jmorrowomni added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Feb 10, 2023
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmorrowomni jmorrowomni force-pushed the improvement/update_pip3 branch from 4ea88bf to 7aab074 Compare February 11, 2023 03:29
@jmorrowomni jmorrowomni merged commit 1f63a52 into develop Feb 11, 2023
@jmorrowomni jmorrowomni deleted the improvement/update_pip3 branch February 11, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

4 participants