Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in Upstream Changes #18

Merged
merged 11 commits into from
Mar 6, 2020
Merged

Pull in Upstream Changes #18

merged 11 commits into from
Mar 6, 2020

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Mar 6, 2020

🗣 Description

This PR pulls in upstream changes that include a fix for a potential pre-commit caching issue and adding mypy as a pre-commit hook.

💭 Motivation and Context

Keepin' things up to date.

🧪 Testing

Just the automated sort.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

felddy and others added 11 commits February 20, 2020 22:14
@felddy
Autoupdate pre-commit hooks. Add mypy.
067ee08
@felddy
Merge pull request #35 from cisagov/improvement/static_type_checking
6369cc6 
Autoupdate pre-commit hooks.  Add mypy.
@jsf9k
Add .mypy_cache to .gitignore
bf36608
@jsf9k
Merge pull request #36 from cisagov/improvement/add-mypy-cache-to-git…
c7f339f 
…ignore

Add .mypy_cache to .gitignore
@mcdonnnj
Incorporate the Python version into keys for pip and pre-commit caches.
454864b 
This should resolve the issue seen when the Python version changes before there
is an update to .pre-commit-config.yml which results in pre-commit pointing to
a non-existent Python installation.
@mcdonnnj
Merge pull request #37 from cisagov/add_python_version_to_cache_keys
b58f7a1 
Incorporate the Python version into keys for pip and pre-commit caches.
@mcdonnnj
Change the cache paths from hardcoded values in their appropriate blo…
478f168 
…cks to environment variables declared before the job block.
@mcdonnnj
Merge pull request #38 from cisagov/change_cache_paths_to_env_variables
241484a 
Change Cache Paths to Environment Variables
@mcdonnnj
Add a rule for markdownlint to allow multiple headers with the same n…
d791334 
…ame as long

as they are not nested in the same heading group.
@mcdonnnj
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
f5fd431 
Add markdownlint Configuration Option for MD024
@mcdonnnj
Merge branch 'develop' of github.com:cisagov/skeleton-generic into im…
1b06ce2 
…provements/pull_upstream_changes
@mcdonnnj mcdonnnj requested review from dav3r, felddy, jsf9k and a team as code owners March 6, 2020 14:41
@mcdonnnj mcdonnnj self-assigned this Mar 6, 2020
jsf9k
jsf9k approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dav3r
dav3r approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@mcdonnnj mcdonnnj merged commit 675cdd3 into develop Mar 6, 2020
@mcdonnnj mcdonnnj deleted the improvements/pull_upstream_changes branch March 6, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @felddy