Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the bump_version.sh script #201

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Replace the bump_version.sh script #201

merged 3 commits into from
Dec 6, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Dec 2, 2024

🗣 Description

This pull request replaces the existing bump_version.sh script with the updated bump-version script.

💭 Motivation and context

This modernizes the script that manages versions in our Docker projects.

🧪 Testing

Automated tests pass. I verified that ./bump-version show works as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj
Pull in the bump-version script from cisagov/pre-commit-packer
4f86062
@mcdonnnj
Modify the bump-version script for this repository
b780601 
Copy over necessary changes from the `bump_version.sh` script.
@mcdonnnj
Remove the bump_version.sh script
e3bc34a 
This functionality has been replaced by the `bump-version` script.
@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Dec 2, 2024
@mcdonnnj mcdonnnj self-assigned this Dec 2, 2024
dav3r
dav3r approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit ea0bf84 Dec 6, 2024
17 checks passed
@mcdonnnj mcdonnnj deleted the improvement/update_bump_version_script branch December 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r