Use the docker/metadata-action GitHub Action to generate our image metadata
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
dv4harr10
approved these changes
Jan 10, 2025
jsf9k
approved these changes
Jan 10, 2025
mcdonnnj
added
the
kraken 🐙
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Switch to using the docker/metadata-action GitHub Action to generate Docker image metadata. This replaces manually specifying the labels and calculating appropriate tags. This approach will both be easier as well as eliminate some of the issues we've had with manually calculating the image tags.
Update the test configuration to only check the org.opencontainers.image.version label on releases. We must make this change because the docker/metadata-action will only populate the label with an appropriate value on a release. Otherwise it will be the branch that is sourced when building the image.
mcdonnnj
force-pushed
the
improvement/use_metadata-action
branch
from
c02089c to
5698c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request switches from using our own metadata generation to using the docker/metadata-action GitHub Action.
💭 Motivation and context
Instead of rolling our own solution to generating the appropriate labels and tags to apply to our Docker image configurations it make sense to leverage a tool managed by Docker.
🧪 Testing
Automated tests pass. I checked the image on Docker Hub and saw the expected tags. I pulled the branch tag and inspected the image to verify the expected image labels.
✅ Pre-approval checklist