Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment explaining why we pin semver #208

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add a comment explaining why we pin semver #208

wants to merge 2 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 15, 2025 •
edited
Loading

🗣 Description

This pull request adds a comment explaining why we must pin semver>=3.

💭 Motivation and context

It is good to document these requirements so we don't wonder about them in the future.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Jan 15, 2025
@jsf9k jsf9k mentioned this pull request Jan 15, 2025
Merged
7 tasks
dav3r
dav3r approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mcdonnnj
mcdonnnj approved these changes Jan 15, 2025
View reviewed changes
requirements-dev.txt Outdated Show resolved Hide resolved
@jsf9k jsf9k requested a review from a team January 15, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @dv4harr10