Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Version Missing from actions/cache Key #40

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR adds the installed Python version as an element of the cache key used in the test job of the build workflow.

💭 Motivation and Context

When I was looking over #39 I noticed that the test job did not have the Python version in its actions/cache key. This is an oversight that slipped through, but needs to be fixed.

🧪 Testing

Automated testing passes.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Nov 18, 2020
@mcdonnnj mcdonnnj self-assigned this Nov 18, 2020
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great minds think alike!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@mcdonnnj mcdonnnj merged commit dc1b7c7 into develop Nov 18, 2020
@mcdonnnj mcdonnnj deleted the bugfix/fix_incorrect_caching branch November 18, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants