Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a requirements-dev.txt pip Requirements File #45

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Add a requirements-dev.txt pip Requirements File #45

merged 2 commits into from
Feb 17, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR adds a requirements-dev.txt file back to this repository.

💭 Motivation and context

Other skeleton projects have a requirements-dev.txt file even if they are not Python projects:

Since the documentation in CONTRIBUTING.md uses this file, and other skeletons have this file, I feel it best to align this project with our other skeletons instead of changing the documentation.

🧪 Testing

Automated testing passes.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Add a requirements-dev.txt pip requirements file
6e33a4e 
Our other skeletons have this file, even if they are not Python projects. The
directions in CONTRIBUTING.md reference such a file, which can be misleading.
Rather than amending the CONTRIBUTING documentation, I feel it's better to
align with our other skeletons for consistency.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation labels Feb 16, 2021
@mcdonnnj mcdonnnj self-assigned this Feb 16, 2021
jsf9k
jsf9k approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent addition!

dav3r
dav3r approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

hillaryj
hillaryj approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@mcdonnnj mcdonnnj merged commit 6474357 into develop Feb 17, 2021
@mcdonnnj mcdonnnj deleted the bug/add_requirements-dev_file branch February 17, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@hillaryj hillaryj hillaryj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @hillaryj @dav3r