Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the Agency Name for Docker Images #47

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Correct the Agency Name for Docker Images #47

merged 2 commits into from
Feb 17, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR fixes the agency name that is used in labels for generated Docker images.

💭 Motivation and context

We should be using the correct naming and information for our projects.

🧪 Testing

Automated tests pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Feb 17, 2021
@mcdonnnj mcdonnnj self-assigned this Feb 17, 2021
hillaryj
hillaryj approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎵 you never even called me by my name 🎵

but now we do. 🎉

jsf9k
jsf9k approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

dav3r
dav3r approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

@mcdonnnj mcdonnnj merged commit 6012923 into develop Feb 17, 2021
@mcdonnnj mcdonnnj deleted the improvement/fix_agency_name branch February 17, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@hillaryj hillaryj hillaryj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @hillaryj @dav3r