Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable container publication to GitHub Container Registry. #49

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

felddy
Copy link
Member

@felddy felddy commented Mar 25, 2021

🗣 Description

Adds the ability for the images generated in the actions workflows to be pushed to the Github Container Registry.

Images are now pushed to both registries.

💭 Motivation and Context

DockerHub is increasingly hostile towards open projects and the teams that support them.

  • team size limits
  • image pull limits
  • image retention limits

This is a hedge against DockerHub spontaneously disabling support for all free projects, and a stepping stone towards adding ECR support.

🧪 Testing

Tested locally and in CI. And in a personal project.

A package has already been generated and published to registries as a result of this branch:

All cisagov packages in a single location:

📷 Screenshots (if appropriate)

kiwi

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow project standards.
  • All relevant repo and/or project documentation has been updated to reflect
    the changes in this PR.
  • All new and existing tests pass.

* Duplicates DockerHub tags for ghcr.io
* Adds login to GitHub Container Registry using the GITHUB_TOKEN secret.
* Documentation update to reflect multi-registry publication.
@felddy felddy added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github_actions labels Mar 25, 2021
@felddy felddy requested review from jsf9k, hillaryj, dav3r and mcdonnnj March 25, 2021 22:03
@felddy felddy self-assigned this Mar 25, 2021
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥡

@felddy felddy added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Mar 26, 2021
@felddy
Copy link
Member Author

felddy commented Mar 26, 2021

Waiting for the Krakening... pass it on.

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid improvement 💪

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me. 👍 👍 🚫 🐳

@felddy felddy removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Apr 26, 2021
@mcdonnnj mcdonnnj merged commit 1c8c7d0 into develop Jun 3, 2021
@mcdonnnj mcdonnnj deleted the improvement/gh_registry branch June 3, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

5 participants