-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable container publication to GitHub Container Registry. #49
Conversation
* Duplicates DockerHub tags for ghcr.io * Adds login to GitHub Container Registry using the GITHUB_TOKEN secret. * Documentation update to reflect multi-registry publication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥡
Waiting for the Krakening... pass it on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid improvement 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me. 👍 👍 🚫 🐳
Co-authored-by: Nick M. <[email protected]>
🗣 Description
Adds the ability for the images generated in the actions workflows to be pushed to the Github Container Registry.
Images are now pushed to both registries.
💭 Motivation and Context
DockerHub is increasingly hostile towards open projects and the teams that support them.
This is a hedge against DockerHub spontaneously disabling support for all free projects, and a stepping stone towards adding ECR support.
🧪 Testing
Tested locally and in CI. And in a personal project.
A package has already been generated and published to registries as a result of this branch:
All cisagov packages in a single location:
📷 Screenshots (if appropriate)
✅ Checklist
the changes in this PR.