Pin package for ansible-lint in pre-commit
#180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
8 tasks
jsf9k
force-pushed
the
improvement/pin-packages-for-ansible-lint
branch
2 times, most recently
from
933a6e6 to
2336d87
Compare
dav3r
approved these changes
May 6, 2024
dv4harr10
approved these changes
May 6, 2024
See skeleton-ansible-role#178 for more details. Co-authored-by: Nick <[email protected]>
The line is not only unnecessary, it was commented out to boot!
jsf9k
force-pushed
the
improvement/pin-packages-for-ansible-lint
branch
from
2336d87 to
1ab9eca
Compare
jsf9k
added
the
kraken 🐙
mcdonnnj
approved these changes
May 7, 2024
…lint On its own ansible-lint does not pull in ansible, only ansible-core. Therefore, if an Ansible module lives in ansible instead of ansible-core, the linter will complain that the module is unknown. In these cases it is necessary to add the ansible package itself as an additional dependency, with the same pinning as is done in requirements-test.txt of cisagov/skeleton-ansible-role.
|
We can close this pull request because a new version of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request pins
ansible-corewhen runningansible-lintinpre-commit. It also adds a comment explaining why the Python packageansiblemay sometimes need to be added as an additional dependency for theansible-lintlinter in.pre-commit-config.yaml.💭 Motivation and context
This is done to match the pinning that was done in cisagov/skeleton-ansible-role#193.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist