Improvement/use ed25519 temporary key pair #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many Linux distributions are now disallowing the use of RSA keys by default, so it makes sense to use an ED25519 key instead. Co-authored-by: Nick <[email protected]>
jsf9k
added
blocked
mcdonnnj
approved these changes
Feb 21, 2022
mcdonnnj
reviewed
Feb 21, 2022
There was a problem hiding this comment.
improvement/use_hcl2...improvement/use-ed25519-temporary-key-pair is helpful for reviewing this PR.
Co-authored-by: Nick <[email protected]>
cisagovbot
pushed a commit
that referenced
this pull request
Apr 1, 2022
…s/setup-python-3 Bump actions/setup-python from 2 to 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the
packerconfiguration to use an ED25519 temporary key pair instead of the default RSA key pair.Please note that #98 must be merged before this pull request. This branch must also be rebased after merging #98.
💭 Motivation and context
Linux distributions are starting to disallow the use of RSA keys by default, so it makes sense to use an ED25519 key instead.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist