Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #229

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Mar 9, 2023

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone [email protected]:cisagov/skeleton-packer.git skeleton-packer
    cd skeleton-packer
    git remote add skeleton https://github.com/cisagov/skeleton-generic.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .github/labels.yml 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • Remove any of the following that do not apply.

  • If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.

  • All relevant type-of-change labels have been added.

  • All new and existing tests pass.


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 4 commits January 31, 2023 13:06
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back to be updated independently to v6.
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Mar 9, 2023
@mcdonnnj mcdonnnj marked this pull request as ready for review March 9, 2023 20:42
@mcdonnnj mcdonnnj requested review from dav3r, jsf9k and a team March 9, 2023 20:42
@mcdonnnj
Copy link
Member

mcdonnnj commented Mar 9, 2023

This just realigns the git history with what is pulled down from cisagov/skeleton-generic as these pull requests keep getting created post-merge of #217 (see #224 and #225).

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

Copy link
Contributor

@jmorrowomni jmorrowomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a lot of changes to go through, but I think it's ok

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mcdonnnj mcdonnnj assigned jmorrowomni and unassigned mcdonnnj Mar 9, 2023
@jmorrowomni jmorrowomni merged commit 679632a into develop Mar 10, 2023
@jmorrowomni jmorrowomni deleted the lineage/skeleton branch March 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
Development

Successfully merging this pull request may close these issues.

6 participants