Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables in the prerelease.yml workflow #314

Merged
merged 1 commit into from
May 11, 2024
Merged

Remove unused variables in the prerelease.yml workflow #314

merged 1 commit into from
May 11, 2024

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request removes some variable arguments that were forgotten in #98 (and more specifically in b2e5cf8).

💭 Motivation and context

This cleans things up to match the same steps in the build.yml and release.yml workflows.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Remove unused variables in the prerelease.yml workflow
e6d15de 
These were missed in #98 (in
b2e5cf8
specifically).
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels Mar 13, 2024
@mcdonnnj mcdonnnj self-assigned this Mar 13, 2024
dav3r
dav3r approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k added this pull request to the merge queue May 11, 2024
Merged via the queue into develop with commit d84cb8c May 11, 2024
9 checks passed
@jsf9k jsf9k deleted the improvement/remove_unused_variables branch May 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r