Fix the formatting for commented out ignore directives #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commented out ignore directives for the pip package ecosystem are formatted in such a way that doing a multiline uncomment with an IDE will not produce valid YAML.
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
dv4harr10
approved these changes
Apr 3, 2024
dav3r
approved these changes
Apr 3, 2024
jsf9k
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adjust the formatting for the pip package ecosystem's commented out ignore directives.
💭 Motivation and context
I was asleep at the wheel when reviewing #315 and missed the formatting. When you uncomment these directives downstream you get malformed YAML due to incorrect spacing.
🧪 Testing
Automated tests pass. I verified that it uncomments correctly and this also matches the formatting for all other commented out ignore directives in the file.
✅ Pre-approval checklist