Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment explaining why we require semver>=3 #392

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 17, 2025

🗣 Description

This pull request adds a comment explaining why we must pin semver>=3.

💭 Motivation and context

It is good to document these requirements so we don't wonder about them in the future.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Jan 17, 2025
@jsf9k jsf9k marked this pull request as ready for review January 17, 2025 03:48
@jsf9k jsf9k requested a review from a team January 17, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: In Progress
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

4 participants