-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a /usr/bin/python3 symlink to the installed python #58
Conversation
When Ansible runs it will look for /usr/bin/python3 and use it if it finds it. Therefore we need /usr/bin/python3 to point to the desired python when packer runs. This change will hose other tasks that expect to find the system python at /usr/bin/python3, though, so we undo the change after running packer. Resolves #56.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix here, but please consider my request to enhance the comment slightly. 🔗
Also polish up the language a bit. Co-authored-by: Dave Redmin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellente! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for researching and fixing this issue. 🐧 I had a few comments for your consideration.
Co-authored-by: Nicholas McDonnell <[email protected]>
Co-authored-by: Nicholas McDonnell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐍
🗣 Description
Resolves #56.
💭 Motivation and Context
When Ansible runs it will look for
/usr/bin/python3
and use it if it finds it; therefore, when Packer runs we need/usr/bin/python3
to point to the python executable that we installed via thesetup-python
action.This change will hose other tasks that expect to find the system python at
/usr/bin/python3
, though, so we undo the change after running Packer.🧪 Testing
I made the same changes in cisagov/kali-packer@b3a5c6f and verified there that they resulted in the correct
python3
executable being used.✅ Checklist