Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several places where I neglected to remove references to PY_VERSION env var #59

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix several places where I neglected to remove references to PY_VERSION env var #59

merged 1 commit into from
Nov 18, 2020

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 18, 2020 •
edited
Loading

🗣 Description

In this pull request I fix several places in the GitHub Actions workflows where I neglected to remove references to the PY_VERSION environment variable.

💭 Motivation and Context

This should have been done as part of merging in the latest lineage pull request.

🧪 Testing

All GitHub Actions pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Nov 18, 2020
@jsf9k jsf9k self-assigned this Nov 18, 2020
@jsf9k jsf9k marked this pull request as ready for review November 18, 2020 20:55
hillaryj
hillaryj approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

mcdonnnj
mcdonnnj approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤕

@jsf9k jsf9k merged commit a07d31c into develop Nov 18, 2020
@jsf9k jsf9k deleted the bugfix/fix-old-python-env-var-references branch November 18, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@hillaryj hillaryj hillaryj approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @hillaryj @mcdonnnj