Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Unmodified pre-commit Configuration in GitHub Actions Workflow #60

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR removes the customized pre-commit configuration that was added because of issues we were having with the terraform_validate hook.

💭 Motivation and Context

This customization is no longer required because the offending hook is disabled per

# There are ongoing issues with how this command works. This issue
# documents the core issue:
# https://github.com/hashicorp/terraform/issues/21408
# We have seen issues primarily with proxy providers and Terraform code
# that uses remote state. The PR
# https://github.com/hashicorp/terraform/pull/24887
# has been approved and is part of the 0.13 release to resolve the issue
# with remote states.
# The PR
# https://github.com/hashicorp/terraform/pull/24896
# is a proprosed fix to deal with `terraform validate` with proxy
# providers (among other configurations).
# We have decided to disable the terraform_validate hook until the issues
# above have been resolved, which we hope will be with the release of
# Terraform 0.13.
# - id: terraform_validate

🧪 Testing

The Actions workflow completes successfully as expected.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

This custom configuration is no longer needed because the hook causing issues
is now disabled in `.pre-commit-config.yaml`.
@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Nov 23, 2020
@mcdonnnj mcdonnnj self-assigned this Nov 23, 2020
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@mcdonnnj mcdonnnj merged commit 2d76637 into develop Dec 3, 2020
@mcdonnnj mcdonnnj deleted the bugfix/remove_custom_pre-commit branch December 3, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants