Add AMI build job to build workflow #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test build goes through the process of building an AMI but does not actually create it. This is an good thing to add since it will catch changes that cause the AMI build process to fail. Currently these changes are only caught when we create a pre-release or release.
The build job can be an expensive test, so we don't want to bother running it unless the other jobs pass.
jsf9k
added
blocked
jsf9k
force-pushed
the
improvement/add-ami-build-to-build-workflow
branch
from
1df0ec7 to
f899682
Compare
jsf9k
changed the title
6 tasks
felddy
approved these changes
Jul 12, 2021
dav3r
approved these changes
Jul 13, 2021
mcdonnnj
requested changes
Jul 13, 2021
There was a problem hiding this comment.
This is a great improvement. I have some suggestions that are mostly to bring this into alignment with the work in cisagov/skeleton-generic#82.
Co-authored-by: dav3r <[email protected]>
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
This mirrors what was done in cisagov/skeleton-generic#82. Co-authored-by: Nick M. <[email protected]>
mcdonnnj
approved these changes
Jul 14, 2021
Co-authored-by: Nick M. <[email protected]>
This is how it's done in [the cisagov/skeleton-python-library build job](https://github.com/cisagov/skeleton-python-library/blob/4ef2364701c0db074c423f740062b2d7c197bea8/.github/workflows/build.yml#L113). Co-authored-by: Nick M. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a
buildtask to thebuildworkflow. This new task goes through the process of building a new AMI but does not actually register it.This pull request is blocked until we move to Packer 1.7 (see #70 and cisagov/setup-env-github-action#32), since that is where support for the
skip_create_amikey was added for Packer configurations (see the first bullet).💭 Motivation and context
This is a useful feature to add since it will catch changes that cause the AMI build process to fail. Currently these changes are only caught when we create a pre-release or release.
N.B.: Once we have dev, staging, and production COOL environments we could allow this job to go ahead and register the AMI in the dev environment. That would allow us to fully test in the dev environment before we create a pre-release (for staging) and/or a release (for production).
🧪 Testing
cisagov/setup-env-github-action#32 was merged and now all
pre-commithooks and GitHub Actions workflows pass.✅ Checklist
build/buildjob to the list of GH Actions jobs that must pass before a PR can be merged.