Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NTP client configured for AWS #79

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Add NTP client configured for AWS #79

merged 2 commits into from
Aug 25, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Aug 4, 2021 •
edited
Loading

🗣 Description

This pull request adds the chrony NTP client and configures it for AWS.

💭 Motivation and context

This addition is necessary to keep every machine's clock in sync, which is in turn critical when comparing logs from different machines. This addition was made manually for some descendants of this repository but not others, but I think it makes sense to include in all AMIs.

🧪 Testing

All pre-commit hooks pass and these changes are already present in, for example, cisagov/teamserver-packer.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Add AWS-configured chrony NTP client
f42fbe6 
This is necessary to keep every machine's clock in sync, which is
critical for comparing logs from different machines.  This addition
was made manually for some descendants of skeleton-packer but not
others, but I think it makes sense to include in all AMIs.
@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Aug 4, 2021
@jsf9k jsf9k self-assigned this Aug 4, 2021
@jsf9k jsf9k changed the title Add AWS-configured chrony NTP client Add NTP client configured for AWS Aug 4, 2021
@jsf9k jsf9k marked this pull request as ready for review August 4, 2021 19:46
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners August 4, 2021 19:46
dav3r
dav3r approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synchronize watches! ⌚

mcdonnnj
mcdonnnj approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and... mark! ⌚

@mcdonnnj mcdonnnj merged commit d1f7194 into develop Aug 25, 2021
@mcdonnnj mcdonnnj deleted the improvement/add-chrony branch August 25, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj