Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete EFS/python2 blurb that is now incorrect #88

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Delete EFS/python2 blurb that is now incorrect #88

merged 1 commit into from
Oct 20, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 21, 2021 •
edited
Loading

🗣 Description

This pull request removes a blurb about aws/efs-utils and Python 2 that is now incorrect. (aws/efs-utils no longer requires Python 2). It also alphabetizes the roles installed in aws.yml since aws/efs-utils no longer needs to be the last thing installed.

💭 Motivation and context

@mcdonnnj pointed out that aws/efs-utils no longer requires Python 2 in cisagov/terraformer-packer#5.

🧪 Testing

All GitHub Actions checks pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k @mcdonnnj
Delete EFS/python2 blurb that is now incorrect
384ad15 
Also alphabetize the roles now that amazon_efs_utils no longer needs
to be the last thing installed.

Co-authored-by: Nick M <[email protected]>
@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label Sep 21, 2021
@jsf9k jsf9k self-assigned this Sep 21, 2021
@jsf9k jsf9k mentioned this pull request Sep 21, 2021
Merged
9 tasks
dav3r
dav3r approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Nice catch @mcdonnnj! 🦅

@jsf9k jsf9k marked this pull request as ready for review September 21, 2021 14:15
@jsf9k jsf9k requested review from felddy and mcdonnnj September 21, 2021 14:15
mcdonnnj
mcdonnnj approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Sep 21, 2021
@jsf9k jsf9k added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Oct 1, 2021
@mcdonnnj mcdonnnj force-pushed the documentation/remove-unnecessary-blurb-re-efs-and-python2 branch from 5b8ae24 to 384ad15 Compare October 20, 2021 20:07
@mcdonnnj mcdonnnj merged commit 6325f9f into develop Oct 20, 2021
@mcdonnnj mcdonnnj deleted the documentation/remove-unnecessary-blurb-re-efs-and-python2 branch October 20, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj