Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Terraform 1.0 #89

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Support Terraform 1.0 #89

merged 2 commits into from
Sep 22, 2021

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Sep 21, 2021

🗣 Description

This PR moves this skeleton from Terraform 0.14 to 1.0.

💭 Motivation and context

This is the last step in our journey of migrating Terraform to a current 1.0.x version. We previously upgraded from Terraform 0.12 to 0.13 with #82 and from 0.13 to 0.14 with #86.

This PR is a part of cisagov/cool-system#219 and related to cisagov/setup-env-github-action#41.

This PR is similar to cisagov/skeleton-tf-module#64 and cisagov/skeleton-ansible-role-with-test-user#29.

When all testing has been completed with Terraform 1.0 and cisagov/setup-env-github-action#41 has been merged, 1075951 will be reverted in a new pull request.

🧪 Testing

To test this PR, I installed Terraform 1.0.7 on my local system and validated the following:

  • All pre-commit tests pass locally
  • All GitHub actions pass for this PR
  • I was able to successfully terraform apply without any errors in all workspaces of the terraform-build-user/ and terraform-post-packer/ directories

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

This change will be reverted when all of our testing is completed.
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Sep 21, 2021
@dav3r dav3r self-assigned this Sep 21, 2021
@dav3r dav3r marked this pull request as ready for review September 22, 2021 15:05
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dav3r dav3r merged commit bc5d812 into develop Sep 22, 2021
@dav3r dav3r deleted the improvement/support_tf_1.0 branch September 22, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants