Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra dash on Packer CLI flag #92

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Remove extra dash on Packer CLI flag #92

merged 1 commit into from
Oct 20, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 8, 2021 •
edited
Loading

🗣 Description

This pull request removes an extra dash on the timestamp-ui flag for the Packer CLI.

💭 Motivation and context

Hashicorp tools prefer single dashes, even for the long version of flags.

🧪 Testing

All GitHub Actions checks pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 8, 2021
@jsf9k jsf9k self-assigned this Oct 8, 2021
@jsf9k jsf9k marked this pull request as ready for review October 8, 2021 17:33
dav3r
dav3r approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashing! ⚔️

mcdonnnj
mcdonnnj approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golang command line options strike again!

cisagovbot pushed a commit that referenced this pull request Oct 19, 2021
@mcdonnnj
Merge pull request #92 from cisagov/improvement/use_action_outputs
ee39ac5 
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
@jsf9k @mcdonnnj
Remove extra dash on the "timestamp-ui" flag for the Packer CLI
f3c7df3 
Hashicorp tools prefer single dashes, even for the long version of
flags.
@mcdonnnj mcdonnnj force-pushed the improvement/remove-extra-dash branch from 4141096 to f3c7df3 Compare October 20, 2021 19:38
@mcdonnnj mcdonnnj merged commit 46bc946 into develop Oct 20, 2021
@mcdonnnj mcdonnnj deleted the improvement/remove-extra-dash branch October 20, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj