Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore tfvars files #94

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Ignore tfvars files #94

merged 3 commits into from
Nov 4, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 26, 2021

🗣 Description

This pull request adds *.tfvars to .gitignore.

💭 Motivation and context

With the changes in #91, there will sometimes be *.tfvars files in the terraform-post-packer subdirectory that should not be committed.

🧪 Testing

These same changes were made in cisagov/freeipa-server-packer#70 to great fanfare.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Oct 26, 2021
@jsf9k jsf9k self-assigned this Oct 26, 2021
@jsf9k jsf9k mentioned this pull request Oct 26, 2021
Merged
1 task
dav3r
dav3r approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k marked this pull request as ready for review October 26, 2021 15:16
@jsf9k jsf9k requested review from felddy and mcdonnnj as code owners October 26, 2021 15:16
mcdonnnj
mcdonnnj approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mcdonnnj mcdonnnj merged commit 7085903 into develop Nov 4, 2021
@mcdonnnj mcdonnnj deleted the improvement/ignore-tfvars-files branch November 4, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj