Specify all variables as non-nullable
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we need not worry about whether variables are explicitly specified as null. Since this is not something we were expecting, it makes sense to avoid the situation. See also: https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values
jsf9k
added
improvement
|
The |
|
No concerns here. We are using version 1.5.7 in our GH Actions workflows. |
dv4harr10
approved these changes
Oct 9, 2024
Version 1.1 of Terraform is the first version to support the nullable key in variable definitions. Also update the comment associated with this line to something a bit more truthful, since we are using 1.5.7 in cisagov/setup-env-github-action. Co-authored-by: David Redmin <[email protected]>
jsf9k
force-pushed
the
improvement/specify-variables-as-non-nullable
branch
from
43ef99c to
c551420
Compare
See commit c551420. |
|
Hi Shane @jsf9k, the Readme file still shows the reference to terraform ~> 1.0 |
|
Hi Shane @jsf9k, under directory examples/basic_usage: same for Readme file and version.tf there reference to terraform ~> 1.0 |
jsf9k
force-pushed
the
improvement/specify-variables-as-non-nullable
branch
from
f9bf064 to
139eefd
Compare
Co-authored-by: David Harris <[email protected]>
Co-authored-by: David Harris <[email protected]>
jsf9k
force-pushed
the
improvement/specify-variables-as-non-nullable
branch
from
139eefd to
193083a
Compare
mcdonnnj
added a commit
that referenced
this pull request
Nov 13, 2024
In #221 we made all of the variables in the example module non-nullable but did not do the same to the `basic_usage` example. Since it uses variables beyond the requirements of the example module it makes sense to also specify the example's variables as non-nullable.
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request specifies all variables as non-
nullable.💭 Motivation and context
This means that we need not worry about whether variables are explicitly specified as
null. Since this is not something we were expecting, it makes sense to avoid the situation.See also the Terraform documentation.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist